Skip to content

[Security Solution] Webhook - Case Management Connector Follow Ups#137227

Merged
stephmilovic merged 10 commits intoelastic:mainfrom
stephmilovic:cases_webhook_followups
Jul 29, 2022
Merged

[Security Solution] Webhook - Case Management Connector Follow Ups#137227
stephmilovic merged 10 commits intoelastic:mainfrom
stephmilovic:cases_webhook_followups

Conversation

@stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Jul 26, 2022 •
edited by kibanamachine
Loading

Summary

Follow up items from #131762

Issue: #137218

  • Adds unit tests
  • Adds beta badge everywhere applicable for isExperimental in triggers_actions_ui
    Screen Shot 2022-07-26 at 12 54 34 PM
    Screen Shot 2022-07-26 at 12 54 08 PM
    Screen Shot 2022-07-26 at 12 54 14 PM
  • Remove real url from tests
  • Line up URL and method on Update step in Webhook - Case Management Connector form
  • Rename incidentViewUrl to viewIncidentUrl

@stephmilovic stephmilovic added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. auto-backport Deprecated - use backport:version if exact versions are needed Team:Threat Hunting:Explore v8.4.0 labels Jul 26, 2022
@stephmilovic stephmilovic requested review from a team as code owners July 26, 2022 18:55
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 26, 2022

Pinging @elastic/security-solution (Team: SecuritySolution)

@cnasikas cnasikas added backport:prev-minor and removed auto-backport Deprecated - use backport:version if exact versions are needed labels Jul 27, 2022
cnasikas
cnasikas reviewed Jul 27, 2022
View reviewed changes
Copy link
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick follow-up! I noticed the following:

Screenshot 2022-07-27 at 1 53 12 PM

  • The technical preview badge is not showing when you create a rule:

Screenshot 2022-07-27 at 1 56 33 PM

Check here https://elastic.github.io/eui/#/navigation/key-pad-menu. It supports the beta item.

@elastic elastic deleted a comment from cnasikas Jul 27, 2022
@stephmilovic stephmilovic requested a review from a team as a code owner July 27, 2022 18:01
@stephmilovic
Copy link
Contributor Author

stephmilovic commented Jul 27, 2022

@cnasikas I made almost all the fixes requested

  • Added requested tests

  • Added beta badge to EuiKeyPadMenuItem:

    Screen Shot 2022-07-27 at 11 43 15 AM Screen Shot 2022-07-27 at 11 43 42 AM

  • I lined up the badge in the add connector modal:

    Screen Shot 2022-07-27 at 11 49 43 AM

However, I was not able to replicate the misalignment that you had pictured above. Where is that from? I thought it was from the add connector flyout, but the badge is aligned to the right and instead of aligning with the header, aligns to the center of the content:
Screen Shot 2022-07-27 at 11 52 47 AM
Screen Shot 2022-07-27 at 11 52 37 AM
Screen Shot 2022-07-27 at 11 52 30 AM

@stephmilovic
Copy link
Contributor Author

stephmilovic commented Jul 27, 2022

@elasticmachine merge upstream

@kibana-ci
Copy link

kibana-ci commented Jul 29, 2022

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
triggersActionsUi 593 594 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
triggersActionsUi 1.0MB 1.0MB +3.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stephmilovic stephmilovic added the Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// label Jul 29, 2022
@stephmilovic stephmilovic merged commit 2d3d930 into elastic:main Jul 29, 2022
@stephmilovic stephmilovic deleted the cases_webhook_followups branch July 29, 2022 19:59
@kibanamachine kibanamachine mentioned this pull request Jul 29, 2022
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jul 29, 2022
@stephmilovic
[Security Solution] Webhook - Case Management Connector Follow Ups (e…
9c63332 
…lastic#137227)

(cherry picked from commit 2d3d930)
@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 29, 2022

💚 All backports created successfully

Status Branch Result
✅ 8.4

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jul 29, 2022
@kibanamachine @stephmilovic
[Security Solution] Webhook - Case Management Connector Follow Ups (#…
f9ee6db 
…137227) (#137627)

(cherry picked from commit 2d3d930)

Co-authored-by: Steph Milovic <stephanie.milovic@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cnasikas cnasikas cnasikas approved these changes

@semd semd semd approved these changes

Assignees

No one assigned

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. v8.4.0 v8.5.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@stephmilovic @elasticmachine @kibana-ci @kibanamachine @cnasikas @semd